test: add e2e test for OpenCensus to OpenTelemetry metrics migration#1735
Open
khrm wants to merge 2 commits into
Open
test: add e2e test for OpenCensus to OpenTelemetry metrics migration#1735khrm wants to merge 2 commits into
khrm wants to merge 2 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
the
size/L
khrm
force-pushed
the
e2e-otel-metrics-test
branch
5 times, most recently
from
73f1a37 to
292afe2
Compare
Adds TestOTelMetrics, a consolidated e2e test for the OC→OTel metrics migration in Chains (PR tektoncd#1550). Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
ko v0.19.0 introduced strict enforcement that kodata symlinks must not resolve outside the kodata root (ko-build/ko#1619). Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
khrm
force-pushed
the
e2e-otel-metrics-test
branch
from
292afe2 to
e521dd8
Compare
infernus01
reviewed
Jul 1, 2026
Comment on lines
+237
to
+240
| removedMetrics := []string{ | ||
| "tekton_chains_taskrun_signed_total", | ||
| "tekton_chains_pipelinerun_signed_total", | ||
| } |
Member
There was a problem hiding this comment.
We can probably remove these, these metrics never existed I believe. This will pass in all cases.
Member
|
/retest |
Member
|
/ok-to-test |
Member
|
/retest |
Member
|
@khrm e2e are failing, can you have a look please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds TestOTelMetrics, a consolidated e2e test for the OC→OTel metrics migration in Chains (PR #1550). The test creates a TaskRun and a PipelineRun, waits for Chains to sign them, then scrapes the controller /metrics endpoint via port-forward to assert:
Uses expfmt/dto.MetricFamily for proper Prometheus text parsing and a baseline scrape before creating resources to compute deltas, avoiding false positives from earlier test runs.
Relates to #1550
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes